Release v1 #46
Draft
Release v1 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several improvements that could be made to the current UI code. This commit: - Separates "application state" (`struct State`) from "application main loop manager" (`struct App`) - Reorganizes state and UI into a more Elm-like architecture - Extracts widget event listeners, like "clickables" and "draggables", into something reusable - Makes the code more testable - Use tokio for async For now the code is unfinished, the "State rewrite" commits will deal with that
* BrowseScreen: Reorganize refresh methods * [wip] start implementing `update` * Separate Actions from CrosstermEvents * Add <left> <down> <up> <right> to default_config
Previously, you had to specify exactly two colors, now any number of colors is accepted.
* Implement scroll up/down * Extract screen-specific actions into their own update() * A lot more stuff
Now modals receive a lambda that returns an Action. This makes modals
infinitely more reusable than the previous ones. To illustrate, this is
now possible:
```rust
let add_modal = Box::new(
InputModal::new()
.style(Style::default().fg(Color::BrightRed))
.on_commit(|input| Action::AddSong(input))
);
let rename_modal = Box::new(
InputModal::new()
.style(Style::default().fg(Color::Blue))
.on_commit(|input| Action::RenameSongTo(input))
);
```
No special case handling for each type of modal!
Also, modals now send Action::CloseModal when appropriate, which closes
any open modal. Previously each modal had its own match case to close
itself...
Implemented SwapSongUp, SwapSongDown, OpenHelpModal, OpenHotkeyModal and PlayFromModal commands. The only remaining command is now OpenInEditor!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
// TODO: write changelog