-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use chris banes compose-bom. #1530
Conversation
|
||
val composeBom = platform("dev.chrisbanes.compose:compose-bom:2024.05.00-alpha03") | ||
implementation(composeBom) | ||
implementation("androidx.activity:activity-compose") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming only the androidx. namespace things can use this composeBom.
I tried to do it with all of them at first, but some still required explicit versioning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding was that only the libraries listed where were covered
https://developer.android.com/develop/ui/compose/bom/bom-mapping
But that is not case. So I am not sure, you can probably look at the dependencies of the BOM to find out. Which libs are covered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
val composeBom = platform("dev.chrisbanes.compose:compose-bom:2024.05.00-alpha03") | ||
implementation(composeBom) | ||
implementation("androidx.activity:activity-compose") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding was that only the libraries listed where were covered
https://developer.android.com/develop/ui/compose/bom/bom-mapping
But that is not case. So I am not sure, you can probably look at the dependencies of the BOM to find out. Which libs are covered.
According to their setup instructions, it looks like I got em all. |
context: #1502 (comment)