Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instantly mark posts as read once opened in PostListings #1077

Closed

Conversation

twizmwazin
Copy link
Contributor

This stores read posts in the relevant view model and renders them as viewed even if the PostView is out of date. Similar to the instant votes system already in use.

@MV-GH
Copy link
Collaborator

MV-GH commented Jul 21, 2023

Not sure if should post this here or the other PR or just as a separate issue but posts are marked as read in saved and in profile which shouldnt imo.

image

image

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't the right way to handle this. There's a LOT of other info that needs to get synced from the postviewmodel to other viewmodels and vice versa, things like votes, saved, read, newcomments, etc. Read is just one of many.

@twizmwazin
Copy link
Contributor Author

twizmwazin commented Jul 21, 2023

@MV-GH That's a seperate issue but one I can quickly fix later today.

@MV-GH
Copy link
Collaborator

MV-GH commented Jul 21, 2023

Could we just do a consumeReturn on the modified postview and use that to update the list?

@MV-GH
Copy link
Collaborator

MV-GH commented Jul 27, 2023

Will be obsolete once #1025 is merged

@twizmwazin twizmwazin closed this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants