Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix material 3 colors to be more standard, stop using onSurface for everything. #1608

Closed
3 tasks done
dessalines opened this issue Jul 31, 2024 · 0 comments · Fixed by #1614
Closed
3 tasks done

Fix material 3 colors to be more standard, stop using onSurface for everything. #1608

dessalines opened this issue Jul 31, 2024 · 0 comments · Fixed by #1614
Labels
enhancement New feature or request

Comments

@dessalines
Copy link
Member

Pre-Flight checklist

  • Did you check to see if this issue already exists?
  • This is a single feature request. (Do not put multiple feature requests in one issue)
  • This is not a question or discussion. (Use https://lemmy.ml/c/jerboa for that)

Describe The Feature Request Below

I built another android app recently, and found that the material color recomendations are much more standardized than when I started building jerboa.

https://m3.material.io/

This is a placeholder issue to remind me to go over those docs again, as well as every component. Specifically:

  • We are overriding way too many colors, and often using onSurface, where we shouldn't be.
  • I'd still like to keep the layout as flat as possible, but there are a few cases where the default card coloring should be used.
@dessalines dessalines added the enhancement New feature or request label Jul 31, 2024
dessalines added a commit that referenced this issue Aug 6, 2024
@dessalines
Some material 3 cleanups.
733df97 
- Adding a fade to the post body preview.
- Getting rid of muted, using colorScheme.outlined instead.
- Making label-type text use label rather than body style.
- Getting rid of some unecessary surface and onSurface colors.
- Fixes #1608
@dessalines dessalines mentioned this issue Aug 6, 2024
Merged
dessalines added a commit that referenced this issue Aug 13, 2024
@dessalines
Move time ago and score to a flowrow layout (#1615)
b6269b3 
* Some material 3 cleanups.

- Adding a fade to the post body preview.
- Getting rid of muted, using colorScheme.outlined instead.
- Making label-type text use label rather than body style.
- Getting rid of some unecessary surface and onSurface colors.
- Fixes #1608

* Moving post attribution to below title.

- Also separating time from score component.
- Using a start-based flowrow, for better responsiveness.
- Re-organizing PostCard / PostListingCard

* Re-arranging time and scores.

- Moving time into the header bar, right aligned.
- Moving scores back to the action bar.

* Fixing comment node header align.

* Fixing hide vote scores.

* Fixing post report item.

* Make post report name clickable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Some material 3 cleanups. LemmyNet/jerboa
1 participant
@dessalines