Upgrade axum and http #123
Conversation
|
LGTM, cc @Nutomic |
|
Thanks for the PR! Im currently on summer vacation, will review it as soon as I get back to work in September. |
src/actix_web/http_compat.rs
Outdated
| @@ -0,0 +1,29 @@ | |||
| #![allow(clippy::unwrap_used)] | |||
There was a problem hiding this comment.
Get rid of this and do proper error handling with ?, otherwise the code can crash at runtime. I realize that there should be no errors as all values are already validated, but yet the code should be written cleanly.
There was a problem hiding this comment.
@Nutomic Since the author has been inactive recently, maybe merge it first and then make changes?
I believe using .expect() would be appropriate.
There was a problem hiding this comment.
Could also just edit this PR, or branch off it directly.
There was a problem hiding this comment.
(is silently in favor of editing it; I'm using this branch to currently use this project as I'm using a newer version of Axum)
|
Cleaned it and merged, thanks @pbzweihander! Also tagged a new release 0.6.0-alpha1 |
This PR upgrades http to 1.x, and upgrades corresponding crates (axum, reqwest, ...).
Resolves #87
For actix-web support, this PR converts http 1.x types to http 0.2 with naive
unwraping.