Skip to content
This repository has been archived by the owner on Jun 27, 2022. It is now read-only.

LL-8068: Improve the performance of the BLE data transfers #737

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

sportron-ledger
Copy link
Contributor

Tested on android so far, need to be tested with ios as well.
Two changes for BLE transfer boosting:

  • Put the BLE connection priority to high by default to reduce the connection interval.
  • Use write without response to send apdus if such characteristic exists, this new characteristic we'll be provided soon by LNX 2.0.2-rc1 firmware version.

@sportron-ledger sportron-ledger requested a review from a team as a code owner December 9, 2021 13:59
@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #737 (e9de9eb) into master (4bcf5bb) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #737      +/-   ##
==========================================
- Coverage   45.22%   45.13%   -0.10%     
==========================================
  Files          82       82              
  Lines        4957     4967      +10     
  Branches      815      819       +4     
==========================================
  Hits         2242     2242              
- Misses       2698     2708      +10     
  Partials       17       17              
Impacted Files Coverage Δ
packages/devices/src/index.ts 0.00% <ø> (ø)
.../react-native-hw-transport-ble/src/BleTransport.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bcf5bb...e9de9eb. Read the comment docs.

Copy link
Contributor

@juan-cortes juan-cortes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 lgtm

@gre gre merged commit 2c04c96 into LedgerHQ:master Dec 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants