Skip to content
This repository has been archived by the owner on Jun 27, 2022. It is now read-only.

Fix sequence=0 becomes 0xffffffff when signing #698

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

kallerosenbaum
Copy link
Contributor

Also fixed two other non-broken but ugly instances of "if (number | undefined)"

Also fixed two other non-broken but ugly instances of "if (number | undefined)"
@kallerosenbaum
Copy link
Contributor Author

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #698 (9ec9e1a) into master (c090d9e) will increase coverage by 0.04%.
The diff coverage is 81.81%.

❗ Current head 9ec9e1a differs from pull request most recent head ae05f1e. Consider uploading reports for the commit ae05f1e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #698      +/-   ##
==========================================
+ Coverage   45.07%   45.12%   +0.04%     
==========================================
  Files          80       80              
  Lines        4867     4867              
  Branches      785      785              
==========================================
+ Hits         2194     2196       +2     
+ Misses       2659     2657       -2     
  Partials       14       14              
Impacted Files Coverage Δ
packages/hw-app-eth/src/Eth.ts 85.15% <77.77%> (ø)
packages/cryptoassets/src/tokens.ts 74.25% <100.00%> (ø)
packages/hw-app-btc/src/BtcNew.ts 92.20% <100.00%> (ø)
packages/hw-app-eth/src/contracts.ts 72.00% <100.00%> (ø)
packages/hw-app-btc/src/splitTransaction.ts 74.19% <0.00%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c090d9e...ae05f1e. Read the comment docs.

@kallerosenbaum
Copy link
Contributor Author

Copy link
Contributor

@hzheng-ledger hzheng-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Thanks

@gre gre merged commit a18709e into LedgerHQ:master Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants