Skip to content
This repository has been archived by the owner on Jun 27, 2022. It is now read-only.

Added address encoding to algorand app #667

Merged
merged 4 commits into from
Oct 11, 2021
Merged

Conversation

ThomasK33
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #667 (ed07d62) into master (51529a1) will decrease coverage by 0.89%.
The diff coverage is 36.36%.

❗ Current head ed07d62 differs from pull request most recent head 8f7c7d2. Consider uploading reports for the commit 8f7c7d2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #667      +/-   ##
==========================================
- Coverage   43.36%   42.46%   -0.90%     
==========================================
  Files          73       73              
  Lines        4338     4293      -45     
  Branches      722      713       -9     
==========================================
- Hits         1881     1823      -58     
- Misses       2440     2453      +13     
  Partials       17       17              
Impacted Files Coverage Δ
packages/hw-app-algorand/src/Algorand.ts 29.03% <25.00%> (+0.21%) ⬆️
packages/hw-app-algorand/src/utils.ts 38.88% <38.88%> (ø)
packages/hw-app-solana/src/Solana.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12ae784...8f7c7d2. Read the comment docs.

@gre
Copy link
Contributor

gre commented Oct 8, 2021

@ThomasK33 Thanks for this contribution. can you run yarn doc?

@ThomasK33
Copy link
Contributor Author

Sure, do you mind if I add the yarn doc step to the CONTRIBUTING.md file?

@gre gre merged commit 3f09baa into LedgerHQ:master Oct 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants