This repository has been archived by the owner on Jun 27, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This all comes from the context of wanting to expose the model id in a nice way for the proxy transport instead of relying on a fallback to nanoS like we do for
listApps
https://github.com/LedgerHQ/ledger-live-common/blob/master/src/apps/hw.js#L124 we could use thedeviceInfo
we already have access to and enhance it with the device model data. Or even modify the signature ofDeviceInfo
to include the model data at some point.This allows us to unlock LNX proxied LLM development, especially in tasks involving the manager where this nanoS fallback brings storage problems.