Skip to content
This repository has been archived by the owner on Jun 27, 2022. It is now read-only.

Expose a way to get Model from targetId #621

Merged
merged 3 commits into from
Jun 11, 2021

Conversation

juan-cortes
Copy link
Contributor

This all comes from the context of wanting to expose the model id in a nice way for the proxy transport instead of relying on a fallback to nanoS like we do for listApps https://github.com/LedgerHQ/ledger-live-common/blob/master/src/apps/hw.js#L124 we could use the deviceInfo we already have access to and enhance it with the device model data. Or even modify the signature of DeviceInfo to include the model data at some point.

This allows us to unlock LNX proxied LLM development, especially in tasks involving the manager where this nanoS fallback brings storage problems.

Copy link
Contributor

@gre gre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please regenerate documentation for CI to pass.

@juan-cortes
Copy link
Contributor Author

please regenerate documentation for CI to pass.

yarn doc right? committed the changes

@juan-cortes juan-cortes requested a review from gre June 11, 2021 15:03
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #621 (52f4561) into master (c7a45ad) will increase coverage by 0.65%.
The diff coverage is 100.00%.

❗ Current head 52f4561 differs from pull request most recent head 9df7a0f. Consider uploading reports for the commit 9df7a0f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #621      +/-   ##
==========================================
+ Coverage   40.76%   41.42%   +0.65%     
==========================================
  Files          70       70              
  Lines        4006     4010       +4     
  Branches      707      707              
==========================================
+ Hits         1633     1661      +28     
+ Misses       2121     2098      -23     
+ Partials      252      251       -1     
Impacted Files Coverage Δ
packages/cryptoassets/src/currencies.js 100.00% <ø> (ø)
packages/devices/src/index.js 65.11% <100.00%> (+65.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a34afa...9df7a0f. Read the comment docs.

@gre gre merged commit 7184a62 into LedgerHQ:master Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants