-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/FAT-13 Sync Onboarding logic #346
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 60fb9ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #346 +/- ##
============================================
- Coverage 64.18% 47.54% -16.64%
============================================
Files 638 592 -46
Lines 28915 26346 -2569
Branches 7262 6751 -511
============================================
- Hits 18558 12527 -6031
- Misses 10287 13767 +3480
+ Partials 70 52 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Screenshots: ✅
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, the only thing I would change is starting from hex strings instead of byte arrays for the tests, like the actual apdu returned from a device in that case. But I guess it's the same thing
I think to do this, we should unit test |
88ad8fc
to
f20fa5f
Compare
f20fa5f
to
07a57d9
Compare
07a57d9
to
76b0358
Compare
With a synchronous onboarding command added to the cli
76b0358
to
60fb9ef
Compare
📝 Description
3 features in live-common:
❓ Context
live-common
✅ Checklist
📸 Demo
Videos have been posted on Slack from this POC
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.