-
Notifications
You must be signed in to change notification settings - Fork 364
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
51 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
--- | ||
"@ledgerhq/live-common": major | ||
"@ledgerhq/devices": major | ||
"@ledgerhq/hw-app-btc": major | ||
"@ledgerhq/live-cli": patch | ||
"ledger-live-desktop": patch | ||
"live-mobile": patch | ||
"@ledgerhq/hw-app-eth": patch | ||
"@ledgerhq/hw-transport-node-ble": patch | ||
"@ledgerhq/hw-transport-node-hid-noevents": patch | ||
"@ledgerhq/hw-transport-web-ble": patch | ||
"@ledgerhq/hw-transport-webhid": patch | ||
"@ledgerhq/hw-transport-webusb": patch | ||
"@ledgerhq/react-native-hw-transport-ble": patch | ||
"@ledgerhq/icons-ui": patch | ||
"@ledgerhq/react-ui": patch | ||
"has-hash-commit-deps": patch | ||
"@actions/submit-bot-report": patch | ||
"@actions/upload-images": patch | ||
"esbuild-utils": patch | ||
"live-github-bot": patch | ||
"native-modules-tools": patch | ||
--- | ||
|
||
#### Replace [webpack](https://webpack.js.org/) with [vite.js](https://vitejs.dev/) to speed up the ledger live desktop development process. | ||
|
||
To fully embrace the "bundleless" vite.js approach, it is necessary to transpile our packages contained in the monorepository to the ESM format, and [subpath exports](https://nodejs.org/api/packages.html#subpath-exports) have been added to silently map to commonjs or esm depending on the need. | ||
|
||
#### 🔥 BREAKING CHANGES for `@ledgerhq/live-common`, `@ledgerhq/devices` and `@ledgerhq/hw-app-btc` consumers. | ||
|
||
As highlighted [here](https://github.com/nodejs/node#39994), it is not possible to target folders directly when using subpath exports. | ||
|
||
The workaround is to suffix the call with `/index` (or `/`). | ||
|
||
For instance… | ||
|
||
```ts | ||
import * as currencies from "@ledgerhq/live-common/currencies"; | ||
``` | ||
|
||
…must be rewritten to… | ||
|
||
```ts | ||
import * as currencies from "@ledgerhq/live-common/currencies/index;"; | ||
``` | ||
|
||
…or: | ||
|
||
```ts | ||
import * as currencies from "@ledgerhq/live-common/currencies/;"; | ||
``` |