This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
LIVE-1625 Add hide NFT collection feature #2333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove useless dependency to hw-app-btc * Also remove hw-app-eth and hw-app-xrp
* Use design system for Checkbox and Swich components * Removed useless @flow marker on checkbox file
* Rebrand footer navigation * remove log
…ction + some cleanup git statusthis branch now requires a LLC bump
LFBarreto
approved these changes
Mar 25, 2022
| ); | ||
| }; | ||
|
|
||
| const styles = StyleSheet.create({ |
There was a problem hiding this comment.
No need to use StyleSheet if you use native-ui components they implement all of these styles as styled-component props
<View style={styles.menuItem}>
->
<Flex flexDirection="row" alignItems="center" >| ); | ||
| }; | ||
|
|
||
| const styles = StyleSheet.create({ |
There was a problem hiding this comment.
same here you dont need StyleSheet anymore if you need to use styles you cant target via props use styled and extend on it
import styled from "styled-components/native";
const StyledNFTImage = styled(NFTImage)`
borderRadius: 4,
width: 36,
aspectRatio: 1,
overflow: "hidden",
`
LFBarreto
suggested changes
Mar 25, 2022
|
Closed for the rebased version here: #2452 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility of hiding NFT collections from both the account page and the NFT Gallery page.
The hidden collections are visible in the account settings page and can be unhidden there.
Screen_Recording_20220324-171322_LL.DEV.mp4
Type
Feature
Context
LIVE-1625
Parts of the app affected / Test plan
Account page, NFT Gallery and Setting page.
On an account page, long-press an NFT collection to show the hide menu.
On the NFT Gallery, click the 3 dots beside the collection title to show the hide menu.
Go to settings -> accounts -> hidden NFT collections to unhide the collections.
Hidden collections should not be visible in the account page nor the NFT gallery.