-
Notifications
You must be signed in to change notification settings - Fork 113
Support/live 1509 tezos tx flow cleanup #2297
Support/live 1509 tezos tx flow cleanup #2297
Conversation
…l ui fixes and improvements
Thanks for your contribution.
Why /generate-screenshots ?If your PR contains UI related changes, Why /upgrade-llc ?If your PR requires an update to the ledger-live-common library, |
1c2e6ff
to
d188a4e
Compare
src/components/AccountCard.tsx
Outdated
@@ -42,56 +43,60 @@ const AccountCard = ({ | |||
getTagDerivationMode(currency as CryptoCurrency, account.derivationMode); | |||
|
|||
return ( | |||
<Card | |||
<TouchableOpacity | |||
activeOpacity={0.6} | |||
onPress={!disabled ? onPress : undefined} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here since it's now a TouchableOpacity you should simply use the disabled
prop https://reactnative.dev/docs/touchablewithoutfeedback#disabled
src/components/InfoModal.tsx
Outdated
@@ -0,0 +1,158 @@ | |||
// @flow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can remove this
src/components/InfoModal.tsx
Outdated
}; | ||
|
||
type InfoModalProps = ModalProps & { | ||
id?: string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably eslint cries here when it sees "," instead of ";" no?
src/components/InfoModal.tsx
Outdated
return ( | ||
<View style={styles.bulletLine}> | ||
<IconArrowRight size={16} color={colors.smoke} /> | ||
<LText style={styles.bulletLineText} color="smoke"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe use colors from the new design system here?
@@ -0,0 +1,78 @@ | |||
// @flow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be removed
LIVE-1509
ValidateSuccess component rebranded
Tezos Delegation Flow mostly rebranded
External links now using the ui theme colors
InfoModal rebranded
Account Settings Button position in header bar fixed when account name too long
Type
Context
Parts of the app affected / Test plan
22-03-17-16-34-17.mp4