Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

Support/live 1509 tezos tx flow cleanup #2297

Merged
merged 22 commits into from
Mar 17, 2022

Conversation

cgrellard-ledger
Copy link
Contributor

@cgrellard-ledger cgrellard-ledger commented Mar 16, 2022

LIVE-1509

ValidateSuccess component rebranded
Tezos Delegation Flow mostly rebranded
External links now using the ui theme colors
InfoModal rebranded
Account Settings Button position in header bar fixed when account name too long

Type

Context

Parts of the app affected / Test plan

22-03-17-16-34-17.mp4

@github-actions
Copy link

Thanks for your contribution.
To be able to merge in develop branch, you need to:

  • pass the CI
  • if needed, run /generate-screenshots
  • have a dev review
  • have a QA review
  • if needed, /upgrade-llc

Why /generate-screenshots ?

If your PR contains UI related changes,
it might be necessary to regenerate screenshots.

Why /upgrade-llc ?

If your PR requires an update to the ledger-live-common library,
once the PR is merged on develop on ledger-live-common side,
you need to run /upgrade-llc to switch back to ledger-live-common@develop here before merging.

@cgrellard-ledger cgrellard-ledger changed the base branch from develop to support/LIVE-1622-tx-flow-cleanup March 16, 2022 10:22
@cgrellard-ledger cgrellard-ledger marked this pull request as ready for review March 16, 2022 14:21
@cgrellard-ledger cgrellard-ledger requested review from a team as code owners March 16, 2022 14:21
@cgrellard-ledger cgrellard-ledger requested a review from a team as a code owner March 16, 2022 15:10
@LFBarreto LFBarreto force-pushed the support/LIVE-1622-tx-flow-cleanup branch from 1c2e6ff to d188a4e Compare March 16, 2022 17:14
Base automatically changed from support/LIVE-1622-tx-flow-cleanup to LL-7742 March 16, 2022 17:14
@@ -42,56 +43,60 @@ const AccountCard = ({
getTagDerivationMode(currency as CryptoCurrency, account.derivationMode);

return (
<Card
<TouchableOpacity
activeOpacity={0.6}
onPress={!disabled ? onPress : undefined}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here since it's now a TouchableOpacity you should simply use the disabled prop https://reactnative.dev/docs/touchablewithoutfeedback#disabled

@@ -0,0 +1,158 @@
// @flow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove this

};

type InfoModalProps = ModalProps & {
id?: string,
Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger Mar 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably eslint cries here when it sees "," instead of ";" no?

return (
<View style={styles.bulletLine}>
<IconArrowRight size={16} color={colors.smoke} />
<LText style={styles.bulletLineText} color="smoke">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use colors from the new design system here?

@@ -0,0 +1,78 @@
// @flow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be removed

@cgrellard-ledger cgrellard-ledger merged commit e6472b5 into LL-7742 Mar 17, 2022
@cgrellard-ledger cgrellard-ledger deleted the support/LIVE-1509-tezos-tx-flow-cleanup branch March 17, 2022 17:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants