Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

change speculos image to the working version #1935

Merged
1 commit merged into from
May 4, 2022

Conversation

henri-ly
Copy link
Contributor

@henri-ly henri-ly commented May 4, 2022

Context (issues, jira)

Speculos is not working with the latests version, we rollback to a working one

Description / Usage

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@henri-ly henri-ly requested a review from a team May 4, 2022 16:45
@vercel
Copy link

vercel bot commented May 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ledger-live-common ❌ Failed (Inspect) May 4, 2022 at 4:54PM (UTC)

@ghost
Copy link

ghost commented May 4, 2022

Not tested yet but can't really test without merging, we'll revert if needed.

@ghost ghost merged commit 5f96843 into develop May 4, 2022
@ghost ghost deleted the bugfix/speculos-docker-image branch May 4, 2022 17:27
ghost pushed a commit that referenced this pull request May 5, 2022
@ghost ghost mentioned this pull request May 5, 2022
2 tasks
ghost pushed a commit that referenced this pull request May 5, 2022
This was referenced May 5, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant