Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

LIVE-2014 add min version for DOT #1895

Merged
1 commit merged into from
Apr 22, 2022

Conversation

henri-ly
Copy link
Contributor

@henri-ly henri-ly commented Apr 14, 2022

Context (issues, jira)

https://ledgerhq.atlassian.net/browse/LIVE-2014

Description / Usage

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@henri-ly henri-ly requested a review from a team as a code owner April 14, 2022 16:30
@vercel
Copy link

vercel bot commented Apr 14, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/EJEHeCwMJZnAj4VAiSm9VB1ZHkV4
✅ Preview: Failed

@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #1895 (982e88e) into develop (87ffc67) will increase coverage by 3.12%.
The diff coverage is n/a.

❗ Current head 982e88e differs from pull request most recent head 24c349d. Consider uploading reports for the commit 24c349d to get more accurate results

@@             Coverage Diff             @@
##           develop    #1895      +/-   ##
===========================================
+ Coverage    56.31%   59.44%   +3.12%     
===========================================
  Files          450      510      +60     
  Lines        20531    21104     +573     
  Branches      5267     5686     +419     
===========================================
+ Hits         11563    12545     +982     
+ Misses        8941     8538     -403     
+ Partials        27       21       -6     
Impacted Files Coverage Δ
src/apps/support.ts 31.81% <ø> (-68.19%) ⬇️
src/families/crypto_org/api/sdk.ts 16.85% <0.00%> (-78.66%) ⬇️
src/families/celo/hw-app-celo.ts 3.38% <0.00%> (-77.97%) ⬇️
src/families/bitcoin/js-signOperation.ts 21.53% <0.00%> (-75.39%) ⬇️
src/families/bitcoin/networks.ts 5.88% <0.00%> (-74.51%) ⬇️
src/families/celo/js-getFeesForTransaction.ts 26.66% <0.00%> (-73.34%) ⬇️
src/hw/signTransaction/ripple.ts 27.27% <0.00%> (-72.73%) ⬇️
src/families/celo/js-buildTransaction.ts 27.27% <0.00%> (-72.73%) ⬇️
src/families/elrond/api/sdk.ts 22.64% <0.00%> (-71.70%) ⬇️
src/families/solana/js-broadcast.ts 28.57% <0.00%> (-71.43%) ⬇️
... and 358 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87ffc67...24c349d. Read the comment docs.

@ghost
Copy link

ghost commented Apr 21, 2022

@henrily-ledger sorry, need again to sign your commits 😅

@henri-ly henri-ly force-pushed the bugfix/LIVE-2014-polkadot-min-app-version branch from bc4b2b0 to 24c349d Compare April 22, 2022 08:52
@vercel
Copy link

vercel bot commented Apr 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ledger-live-common ❌ Failed (Inspect) Apr 22, 2022 at 8:59AM (UTC)

@ghost ghost merged commit 46c4482 into develop Apr 22, 2022
@ghost ghost deleted the bugfix/LIVE-2014-polkadot-min-app-version branch April 22, 2022 11:56
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant