Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

LL-8834 (BTC-JS) Avoid multiple recipients in operation details #1597

Merged
merged 2 commits into from
Jan 3, 2022

Conversation

ghost
Copy link

@ghost ghost commented Dec 29, 2021

Context (issues, jira)

https://ledgerhq.atlassian.net/browse/LL-8834

Description / Usage

Expectations

Yet another iteration to make sure we don't display multiple recipients (for example the change output) in operation details.

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@ghost ghost self-assigned this Dec 29, 2021
@ghost ghost self-requested a review as a code owner December 29, 2021 16:09
@vercel
Copy link

vercel bot commented Dec 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/CX8SBhwkbHPBR4sHotuKKRhttQBw
✅ Preview: https://ledger-live-common-git-bitcoin-js-ll-8834-ledgerhq.vercel.app

@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #1597 (0461a56) into master (bf018d5) will decrease coverage by 12.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1597       +/-   ##
===========================================
- Coverage   68.27%   56.08%   -12.19%     
===========================================
  Files         581      548       -33     
  Lines       23867    21814     -2053     
  Branches     5687     5319      -368     
===========================================
- Hits        16295    12235     -4060     
- Misses       7474     9530     +2056     
+ Partials       98       49       -49     
Impacted Files Coverage Δ
src/families/bitcoin/js-synchronisation.ts 88.95% <100.00%> (-3.45%) ⬇️
src/libcore/createAccountFromDevice.ts 8.82% <0.00%> (-91.18%) ⬇️
src/families/algorand/libcore-buildSubAccounts.ts 16.36% <0.00%> (-81.82%) ⬇️
src/families/algorand/libcore-buildOperation.ts 15.62% <0.00%> (-81.25%) ⬇️
src/families/cosmos/libcore-buildOperation.ts 4.83% <0.00%> (-80.65%) ⬇️
src/libcore/buildAccount/index.ts 14.58% <0.00%> (-80.21%) ⬇️
src/families/cosmos/libcore-mergeOperations.ts 13.63% <0.00%> (-77.28%) ⬇️
src/families/bitcoin/js-signOperation.ts 20.58% <0.00%> (-76.48%) ⬇️
src/families/crypto_org/api/sdk.ts 16.85% <0.00%> (-75.29%) ⬇️
src/families/crypto_org/js-signOperation.ts 19.69% <0.00%> (-72.73%) ⬇️
... and 173 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf018d5...0461a56. Read the comment docs.

@gre gre merged commit 6582598 into master Jan 3, 2022
@gre gre deleted the bitcoin-js-LL-8834 branch January 3, 2022 10:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants