Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

Add PLATFORM_LOCAL_MANIFEST_JSON env #1586

Merged
merged 5 commits into from
Feb 8, 2022
Merged

Conversation

nabil-brn
Copy link
Contributor

@nabil-brn nabil-brn commented Dec 20, 2021

Context (issues, jira)

We need a way to add dynamically manifest file at the start of the app for automated tests.

Description / Usage

PLATFORM_LOCAL_MANIFEST_JSON="$(cat /path/to/file.json)"

Expectations

On ledger-live-desktop, Platform should load dApps I want for my test.

@vercel
Copy link

vercel bot commented Dec 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/37Pju1seTHTPraEpSchLgjwcMbSQ
✅ Preview: https://ledger-live-common-git-test-platform-local-mani-98f764-ledgerhq.vercel.app

src/platform/PlatformAppProvider/helpers.ts Outdated Show resolved Hide resolved
@nabil-brn nabil-brn requested a review from chabroA January 11, 2022 18:01
@chabroA chabroA force-pushed the test/platform-local-manifest-env branch from de80e74 to 8c9fde4 Compare January 18, 2022 17:14
@chabroA chabroA marked this pull request as ready for review January 18, 2022 17:15
@chabroA chabroA requested a review from a team as a code owner January 18, 2022 17:15
@chabroA chabroA requested a review from a team January 18, 2022 17:15
@chabroA chabroA changed the title Add PLATFORM_LOCAL_MANIFEST_PATH env Add PLATFORM_LOCAL_MANIFEST_JSON env Jan 18, 2022
@chabroA chabroA requested a review from gre January 18, 2022 17:17
@ggilchrist-ledger
Copy link
Contributor

I've tried manually with a manifest and it's working correctly

@chabroA chabroA self-assigned this Jan 24, 2022
@gre gre merged commit 38edada into master Feb 8, 2022
@gre gre deleted the test/platform-local-manifest-env branch February 8, 2022 13:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants