Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

[LL-8263]Altcoin fee fix #1540

Merged
merged 8 commits into from
Nov 26, 2021
Merged

[LL-8263]Altcoin fee fix #1540

merged 8 commits into from
Nov 26, 2021

Conversation

hzheng-ledger
Copy link
Contributor

Fix viacoin fix (fix lower that relay fee and it causes transaction failure)
https://ledgerhq.atlassian.net/browse/LL-8263

@hzheng-ledger hzheng-ledger requested a review from a team November 25, 2021 23:41
@vercel
Copy link

vercel bot commented Nov 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/AWMuwiz6VuKrbAZXoLmXduo4DMNZ
✅ Preview: https://ledger-live-common-git-bitcoin-js-ledgerhq.vercel.app

@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #1540 (8cf2d7a) into master (4629057) will decrease coverage by 17.67%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1540       +/-   ##
===========================================
- Coverage   54.83%   37.16%   -17.68%     
===========================================
  Files         506      438       -68     
  Lines       20404    19745      -659     
  Branches     5050     4691      -359     
===========================================
- Hits        11189     7338     -3851     
- Misses       9170    12390     +3220     
+ Partials       45       17       -28     
Impacted Files Coverage Δ
src/families/bitcoin/types.ts 100.00% <ø> (ø)
src/families/bitcoin/getAccountNetworkInfo.ts 96.66% <100.00%> (+0.66%) ⬆️
src/families/bitcoin/wallet-btc/explorer/index.ts 85.27% <100.00%> (+4.62%) ⬆️
src/currencies/chopCurrencyUnitDecimals.ts 7.14% <0.00%> (-92.86%) ⬇️
src/families/ethereum/mock.ts 6.34% <0.00%> (-92.07%) ⬇️
src/families/cosmos/mock.ts 3.52% <0.00%> (-91.55%) ⬇️
src/currencies/sanitizeValueString.ts 9.37% <0.00%> (-90.63%) ⬇️
src/account/groupOperations.ts 9.52% <0.00%> (-88.89%) ⬇️
src/currencies/CurrencyURIScheme.ts 11.53% <0.00%> (-84.62%) ⬇️
src/families/cosmos/message.ts 5.76% <0.00%> (-84.62%) ⬇️
... and 262 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4629057...8cf2d7a. Read the comment docs.

@gre gre merged commit 2537e28 into master Nov 26, 2021
@gre gre deleted the bitcoin-js branch November 26, 2021 12:50
@LFBarreto LFBarreto mentioned this pull request Dec 3, 2021
2 tasks
@LFBarreto LFBarreto mentioned this pull request Dec 18, 2021
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants