Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

Downgrade polkadot to v6.8.1 #1537

Merged
merged 2 commits into from
Nov 25, 2021
Merged

Downgrade polkadot to v6.8.1 #1537

merged 2 commits into from
Nov 25, 2021

Conversation

ghost
Copy link

@ghost ghost commented Nov 24, 2021

Context (issues, jira)

Upgrading polkadot to v6.9.2 makes it impossible to build LLD and LLM, see https://ledgerhq.atlassian.net/browse/LL-8290.

Temporarily downgrade to v6.8.1 to unblock build of LLD and LLM.

Description / Usage

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@ghost ghost self-requested a review November 24, 2021 15:18
@ghost ghost self-assigned this Nov 24, 2021
@vercel
Copy link

vercel bot commented Nov 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/FjhWS2f75j1Q7mAZTj6nh5bKeXNt
✅ Preview: https://ledger-live-common-git-downgrade-polkadot-ledgerhq.vercel.app

@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #1537 (5250b2d) into master (a1c5214) will decrease coverage by 13.36%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1537       +/-   ##
===========================================
- Coverage   68.39%   55.02%   -13.37%     
===========================================
  Files         535      504       -31     
  Lines       22268    20289     -1979     
  Branches     5377     5015      -362     
===========================================
- Hits        15231    11165     -4066     
- Misses       6943     9079     +2136     
+ Partials       94       45       -49     
Impacted Files Coverage Δ
src/libcore/createAccountFromDevice.ts 8.82% <0.00%> (-91.18%) ⬇️
src/families/elrond/api/apiCalls.ts 14.28% <0.00%> (-82.86%) ⬇️
src/families/algorand/libcore-buildSubAccounts.ts 16.36% <0.00%> (-81.82%) ⬇️
src/families/algorand/libcore-buildOperation.ts 15.62% <0.00%> (-81.25%) ⬇️
src/families/cosmos/libcore-buildOperation.ts 4.83% <0.00%> (-80.65%) ⬇️
src/libcore/buildAccount/index.ts 14.58% <0.00%> (-80.21%) ⬇️
src/families/cosmos/libcore-mergeOperations.ts 13.63% <0.00%> (-77.28%) ⬇️
src/families/bitcoin/js-signOperation.ts 21.87% <0.00%> (-76.57%) ⬇️
src/families/crypto_org/api/sdk.ts 16.85% <0.00%> (-75.29%) ⬇️
src/families/elrond/api/sdk.ts 23.07% <0.00%> (-75.00%) ⬇️
... and 167 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1c5214...5250b2d. Read the comment docs.

@ghost ghost marked this pull request as draft November 24, 2021 16:47
@ghost ghost marked this pull request as ready for review November 24, 2021 17:22
@ghost ghost requested a review from gre November 24, 2021 17:22
@gre gre merged commit 3dd814a into master Nov 25, 2021
@gre gre deleted the downgrade-polkadot branch November 25, 2021 07:12
@LFBarreto LFBarreto mentioned this pull request Dec 3, 2021
2 tasks
@LFBarreto LFBarreto mentioned this pull request Dec 18, 2021
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants