Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

LL-6020 remove Zcoin install key #1311

Merged
merged 1 commit into from
Jul 19, 2021
Merged

LL-6020 remove Zcoin install key #1311

merged 1 commit into from
Jul 19, 2021

Conversation

valpinkman
Copy link
Member

@valpinkman valpinkman commented Jul 19, 2021

Context (issues, jira)

LL-6020

Description / Usage

Removed Zcoin from being installable

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@valpinkman valpinkman requested a review from a team July 19, 2021 15:10
@vercel
Copy link

vercel bot commented Jul 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/2KUgqYvotKW9BMiSZeTFLy1BmQGr
✅ Preview: https://ledger-live-common-git-fork-valpinkman-coin-rem-a67b76-ledgerhq.vercel.app

@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #1311 (28131cf) into master (0151210) will decrease coverage by 5.88%.
The diff coverage is n/a.

❗ Current head 28131cf differs from pull request most recent head 341dcd3. Consider uploading reports for the commit 341dcd3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1311      +/-   ##
==========================================
- Coverage   68.79%   62.90%   -5.89%     
==========================================
  Files         363      342      -21     
  Lines       15371    13788    -1583     
  Branches     4596     4232     -364     
==========================================
- Hits        10574     8673    -1901     
- Misses       4101     4300     +199     
- Partials      696      815     +119     
Impacted Files Coverage Δ
src/manager/index.js 31.70% <ø> (ø)
src/hw/signTransaction/ripple.js 0.00% <0.00%> (-100.00%) ⬇️
src/families/bitcoin/libcore-broadcast.js 0.00% <0.00%> (-100.00%) ⬇️
src/families/algorand/libcore-broadcast.js 0.00% <0.00%> (-100.00%) ⬇️
...families/algorand/libcore-getFeesForTransaction.js 0.00% <0.00%> (-100.00%) ⬇️
src/families/bitcoin/libcore-signOperation.js 0.00% <0.00%> (-97.44%) ⬇️
src/families/algorand/libcore-buildSubAccounts.js 2.12% <0.00%> (-95.75%) ⬇️
src/apps/support.js 6.25% <0.00%> (-93.75%) ⬇️
src/libcore/signOperation.js 6.25% <0.00%> (-90.63%) ⬇️
src/families/algorand/libcore-buildOperation.js 6.89% <0.00%> (-89.66%) ⬇️
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0151210...341dcd3. Read the comment docs.

@gre gre merged commit 910199a into LedgerHQ:master Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants