This repository has been archived by the owner on Jul 15, 2022. It is now read-only.
Error handling + action fix #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/ANc58FVSU3NqFAg5AiNDStFDLpvy |
Codecov Report
@@ Coverage Diff @@
## master #1298 +/- ##
==========================================
- Coverage 66.55% 62.94% -3.62%
==========================================
Files 363 342 -21
Lines 15358 13788 -1570
Branches 4596 4232 -364
==========================================
- Hits 10222 8679 -1543
+ Misses 4373 4295 -78
- Partials 763 814 +51
Continue to review full report at Codecov.
|
valpinkman
approved these changes
Jul 12, 2021
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr prepares to handle the error cases that might arise when interacting with the swap feature with the new provider. Due to the limitations, we have in the KYC form, the error handling is at a generic level and not per field. It also includes a reset mechanism (and disabling of the form) based on a specific error for unauthorized rates for the specified user.
This needs to be tested once all the pieces are in place.
It also includes a fix for the
requireLatestFirmwaremod we introduced, ironically I only made it work for all flows except swap. Thanks @LFBarreto for helping find this bug, I was not passing the flag to the nestedconnectAppinsideinitSwap.Update
Tested against the latest deployed staging, the error handling is as good as we can make it currently. If you are adventurous and want to try it before it gets merged, yalc this version on LLD, and replace your valid ID for wyre in the app.json file with something invalid, for instance, turn your "US_123456" into "_US_123456" and refresh the app. It should let you reach the form but throw the unauthorized error later.