This repository has been archived by the owner on Jul 15, 2022. It is now read-only.
externalize the versioning of platform #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usecase: as LLD/LLM are implementers of the platform, they are the one to provide the version, it's not a constant it allows a true loosely coupling of these parts
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/7C1avZDpQgxBzruDsbDPvm5A5U25 |
valpinkman
approved these changes
Jul 7, 2021
IAmMorrow
approved these changes
Jul 7, 2021
Comment on lines
+12
to
+14
| import { setPlatformVersion } from "../platform/version"; | ||
|
|
||
| setPlatformVersion("0.0.1"); |
There was a problem hiding this comment.
walletconnect and platform are not related 🤔
They could be factorized in the future 👍
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usecase:
as LLD/LLM are implementers of the platform, they are the one to provide the version, it's not a constant
it allows a true loosely coupling of these parts
impact:
LLD/LLM must adapt this:
when there are code that do
setSupportedCurrenciesyou also must addsetPlatformVersion