This repository has been archived by the owner on Jul 15, 2022. It is now read-only.
LL-6072 LL-6161 [Polkadot] Dynamically fetch minimum bond value #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/FhvtFpxyohRhm7Ayy5DAEKjvZJvW |
gre
approved these changes
Jul 6, 2021
gre
reviewed
Jul 6, 2021
src/families/polkadot/preload.js
Outdated
| @@ -56,11 +58,15 @@ function fromHydratePreloadData(data: mixed): PolkadotPreloadData { | |||
| bondingDuration: Number(bondingDuration) || 28, | |||
| }; | |||
| } | |||
|
|
|||
| // $FlowFixMe | |||
| minimumBondBalance = BigNumber(data.minimumBondBalance); | |||
There was a problem hiding this comment.
i think you should do
BigNumber(data.minimumBondBalance || 0)
because there is a slight possibility that you will first get hydrate() WITHOUT the data when coming on old Live. indeed it also get instantly hydrated after this, but still there is a possibility to get a BigNumber NaN here.
This was referenced Jul 15, 2021
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: on Polkadot the minimum amount allowed to bond can now change at any time with a governance decision. We need to fetch it dynamically to adapt the warnings and errors we display to the users.