This repository has been archived by the owner on Apr 1, 2024. It is now read-only.
Update BWTC.js #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The line `BWTC = Object.create(null);` instantiates silently a global variable which is not compatible with [the Javascript Strict mode](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode#converting_mistakes_into_errors) which is [enabled by default](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode#strict_mode_for_modules) when using Javascript modules in a browser. I think that prefixing the variable with a simple `const = ` should fix without causing any harm to the rest of the code. _For the context, I am trying to replace `webpack` with `vite.js` in dev mode for Ledger Live Desktop which threw the error caused by this global allocation._
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @gre 👋
I am trying to replace
webpackwithvite.jsin dev mode for Ledger Live Desktop and I encountered an error while trying it out.The line
BWTC = Object.create(null);instantiates silently a global variable which is not compatible with the Javascript Strict mode which is enabled by default when using Javascript modules in a browser.I think that prefixing the variable with a simple
constshould fix without causing any harm to the rest of the code.