Merge pull request #25 from LedgerHQ/y333/use_allocator

Bump SDK version

.cargo/config.toml

@@ -5,5 +5,5 @@ runner = "speculos -a=1 --model=nanosp"
 target = "nanosplus"
 
 [unstable]
-build-std = ["core"]
+build-std = ["core", "alloc"]
 build-std-features = ["compiler-builtins-mem"]

Cargo.toml

@@ -1,11 +1,11 @@
 [package]
 name = "starknet"
-version = "1.2.1"
+version = "1.2.2"
 edition = "2021"
 authors = ["Ledger"]
 
 [dependencies]
-ledger_device_sdk = "1.10.2"
+ledger_device_sdk = "1.10.5"
 include_gif = "1.1.0"
 hex = { version = "0.4", default-features = false }
 
@@ -27,9 +27,6 @@ path = ["2645'"]
 name = "Starknet"
 flags = "0"
 
-[package.metadata.ledger.nanos]
-icon = "crab.gif"
-
 [package.metadata.ledger.nanox]
 icon = "starknet_small.gif"
 

docs/build.md

@@ -8,10 +8,10 @@ docker pull ghcr.io/ledgerhq/ledger-app-builder/ledger-app-builder
 git clone https://github.com/LedgerHQ/app-starknet.git
 ```
 
-Build for Nano S/S+/X/Stax/Flex:
+Build for Nano S+/X/Stax/Flex:
 ```
 docker run --rm -it -v "$(pwd -P):/apps" ghcr.io/ledgerhq ledger-app-builder/ledger-app-builder
 cd /apps/app-starknet/
 cargo clean
-cargo ledger build nanos|nanosplus|nanox|stax|flex
+cargo ledger build nanosplus|nanox|stax|flex
 ```

docs/test.md

@@ -11,7 +11,7 @@ docker pull ghcr.io/ledgerhq/ledger-app-builder/ledger-app-dev-tools
 docker run --rm -it -v "$(pwd -P):/apps" --publish 5001:5001 --publish 9999:9999 ghcr.io/ledgerhq/ledger-app-builder/ledger-app-dev-tools
 cd /apps/app-starknet
 pip install -r tests/requirements.txt 
-pytest tests/ --tb=short -v --device {nanos | nanosp | nanox | stax | flex}
+pytest tests/ --tb=short -v --device {nanosp | nanox | stax | flex}
 ```
 
 ### Emulator

ledger_app.toml

@@ -1,7 +1,7 @@
 [app]
 build_directory = "./"
 sdk = "Rust"
-devices = ["nanos", "nanox", "nanos+", "stax", "flex"]
+devices = ["nanox", "nanos+", "stax", "flex"]
 
 [tests]
 pytest_directory = "./tests/"

src/display.rs

@@ -61,7 +61,7 @@ pub fn sign_ui(message: &[u8]) -> bool {
             value: hash,
         }];
 
-        let mut review = NbglReview::<1, 256>::new()
+        let mut review = NbglReview::new()
             .titles("Review", "Transaction Hash", "Sign Transaction")
             .glyph(&APP_ICON);
         review.show(&my_fields)
@@ -109,7 +109,10 @@ pub fn pkey_ui(key: &[u8]) -> bool {
         // Load glyph from 64x64 4bpp gif file with include_gif macro. Creates an NBGL compatible glyph.
         const APP_ICON: NbglGlyph =
             NbglGlyph::from_include(include_gif!("starknet_64x64.gif", NBGL));
-        NbglAddressReview::new().glyph(&APP_ICON).show(m)
+        NbglAddressReview::new()
+            .glyph(&APP_ICON)
+            .verify_str("Verify public key")
+            .show(m)
     }
 }