Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pdm): add pdm actions (VG-14148) #115

Merged
merged 1 commit into from
Feb 8, 2024
Merged

feat(pdm): add pdm actions (VG-14148) #115

merged 1 commit into from
Feb 8, 2024

Conversation

@noirbizarre noirbizarre added the enhancement New feature or request label Jan 12, 2024
@noirbizarre noirbizarre force-pushed the feature/pdm branch 10 times, most recently from 8b90303 to 4959498 Compare January 16, 2024 15:51
@noirbizarre noirbizarre force-pushed the feature/pdm branch 6 times, most recently from 9d10146 to 2134415 Compare January 30, 2024 14:34
pdm/doc/build/action.yml Outdated Show resolved Hide resolved
pdm/doc/build/action.yml Show resolved Hide resolved
pdm/docker/action.yml Outdated Show resolved Hide resolved
pdm/meta/action.yml Show resolved Hide resolved
pdm/meta/action.yml Outdated Show resolved Hide resolved
pdm/meta/action.yml Outdated Show resolved Hide resolved
Comment on lines 73 to 87
# Disabled until Nexus is confirmed working
# - name: Push to our internal Nexus
# if: inputs.kind == 'lib' && env.PDM_PUBLISH_USERNAME != null && env.PDM_PUBLISH_PASSWORD != null
# env:
# PDM_PUBLISH_REPO: https://{% raw %}${{ secrets.GREEN_NEXUS_HOST }}{% endraw %}/repository/pypi-internal/
# PDM_PUBLISH_USERNAME: {% raw %}${{ secrets.GREEN_NEXUS_USER }}{% endraw %}
# PDM_PUBLISH_PASSWORD: {% raw %}${{ secrets.GREEN_NEXUS_PASSWORD }}{% endraw %}
# run: pdm publish --no-build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working and used by at least a project so we should keep it enabled for publication of libraries.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to hear it because I have been asking for the past year and each time I was told "it's not working" and then "it's not the target anymore, we are focusing on artifactory pro".
I'll be glad to enable it 🎉 (but I'll need access to test it's working)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I know that at least on project uses it so it better fills it.
However we might drop it to artifactory in the near future for multiple reasons but the discussions are ongoing.
In the meanwhile we want to keep this activated :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I uncommented it, fixed it (but I haven't tested it yet)

slack/release/action.yml Outdated Show resolved Hide resolved
@noirbizarre noirbizarre force-pushed the feature/pdm branch 8 times, most recently from ac1f47c to 886cd4b Compare February 7, 2024 10:16
@noirbizarre noirbizarre force-pushed the feature/pdm branch 8 times, most recently from 6cfd537 to 87ef125 Compare February 7, 2024 14:39
@noirbizarre noirbizarre force-pushed the feature/pdm branch 15 times, most recently from a1ea5f7 to 13ecd0a Compare February 7, 2024 17:26
@noirbizarre noirbizarre merged commit b20c337 into main Feb 8, 2024
2 checks passed
@noirbizarre noirbizarre deleted the feature/pdm branch February 8, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants