-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Bevy to 0.11 #364
Update Bevy to 0.11 #364
Conversation
Appears this just isn't needed anymore as I had removed the others without issue. In 0.10 `#[bundle]` was used, in 0.11 `#[bundle(ignore)]` was added, causing `#[bundle]` to error. I couldn't find mention of how migrate `#[bundle]` but removing it seems to just work.
Yep, placeholder is correct. Why do we need |
This line was complaining without it: leafwing-input-manager/src/plugin.rs Line 146 in dfbe44b
If you remove the TypePath requirement from Actionlike, it gives this error:
I'm open to suggestions, was just added to get it to compile. |
Opened an issue as it seems like it might be an unintentional restriction since it isn't mentioned in the migration guide: Migration guide: https://bevyengine.org/learn/migration-guides/0.10-0.11/#bevy-reflect-stable-type-path-v2 |
Great; doesn't look like something we can work around here. |
Once bevy_egui ships I'll merge this and then cut a release. Thanks a ton! |
|
Done, looking good to go on my end! |
The only thing I wasn't sure about is with input mocking, .11 adds a
window
field to input events that I just populated with Entity::PLACEHOLDER when sending events because our test environment doesn't create a window so all the tests would fail trying to get a window.