Cover Rectangle with unit Tests #8144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Tested initializing - Tested setBounds - Mirrored most tests from PolygonSpec.js
.only was used for testing purposes only. Has been removed
stephenspol
commented
Apr 16, 2022
Falke-Design
requested changes
Apr 16, 2022
- Removed holes tests as they are not necessary - Skipping empty array tests as it throws error - Changed multiple coords test to extending bounds
… into rectangle-test
- Added function () in expectation - Removed skip
Falke-Design
approved these changes
Apr 19, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests cover
initializeandsetBounds. Most tests mirroredPolygonSpec.jsbut had to drop a few tests. Some tests that were mirrored fromPolygonnow fail such as an empty array fails when initializing and setting bounds. I am assuming this is because of_boundsToLatLngsbeing overwritten aslatthrows an error due to being undefined. Rectangle also fails when putting more than 2 coords, not sure if this is attended.Please let me know if anything needs to be changed.
PR closes #8140.