Fix Marker position while zooming #7967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Falke-Design
commented
Feb 4, 2022
| @@ -1697,6 +1700,12 @@ export var Map = Evented.extend({ | |||
| noUpdate: noUpdate | |||
| }); | |||
|
|
|||
| if (!this._tempFireZoomEvent) { | |||
| this._tempFireZoomEvent = this._zoom !== this._animateToZoom; | |||
There was a problem hiding this comment.
we need to store if the zoom is different, to fire later the zoom event.
Falke-Design
commented
Feb 4, 2022
| this._tempFireZoomEvent = this._zoom !== this._animateToZoom; | ||
| } | ||
|
|
||
| this._move(this._animateToCenter, this._animateToZoom, undefined, true); |
There was a problem hiding this comment.
This is the necessary call to set the _pixelOrigin but we need to prevent firing the zoom event (to keep the current behaviour)
JLyne
pushed a commit
to JLyne/Leaflet
that referenced
this pull request
Feb 6, 2022
This was referenced Feb 21, 2022
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a marker is set to a new latlng while zooming the marker jumps around. The problem is that the
this._pixelOrigin(which is used for the calculation of the marker position) is only set after the zoom (_onZoomTransitionEnd), so while zooming the old pixelOrigin is used and the marker jumps.I tried to create a test but it was not possible.
New src: link
Fixed:
