Fixed image size for retina spritesheet icons #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noticed the same, made the same fix to g-leaflet-draw project. Fix looks correct to me. |
|
Nice catch @dwnoble , I must have messed up the maths when I added the new icons the the spritesheet. |
jacobtoye
added a commit
that referenced
this pull request
Nov 19, 2013
Fixed image size for retina spritesheet icons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dist/images/spritesheet-2x.png has dimensions 540 x 60, but the image was being scaled to 210 x 30. This was causing toolbar icons to be rendered incorrectly in a retina display. Corrected scaling to 270 x 30.