Test environment #123
Merged
Test environment #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-added Leaflet and testing dependencies to package.json -added spec folder + test libraries -added 'test' task to build.js and package.json -added karma config file (spec/karma.conf.js) and some miscellaneous spec helpers (leaflet-draw-include.js, leaflet-include.js, leaflet-deps.js)
…es from node_modules
|
Awesome! you rock @iirvine I've been spread pretty thin lately with work commitments, however look forward to getting some test coverage! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I thought it might be about time for this plugin to have some test coverage. To that end I've gone ahead and stubbed out a little test environment.
Mostly just following Leaflet's lead here - Mocha + expect + sinon + karma. npm install and npm test should be all that's needed to get it up and running. All that's left now is actually writing some tests....