Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update readme with docker port mapping #145

Merged
merged 1 commit into from
Dec 20, 2024
Merged

chore: update readme with docker port mapping #145

merged 1 commit into from
Dec 20, 2024

Conversation

BrendanCoughlan5
Copy link
Contributor

@BrendanCoughlan5 BrendanCoughlan5 commented Dec 9, 2024 •
edited
Loading

readme + diagram makes it easier to understand

@BrendanCoughlan5 BrendanCoughlan5 requested a review from a team as a code owner December 9, 2024 23:16
seanmcgary
seanmcgary reviewed Dec 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
seanmcgary
seanmcgary reviewed Dec 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
seanmcgary
seanmcgary reviewed Dec 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
seanmcgary
seanmcgary reviewed Dec 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
seanmcgary
seanmcgary requested changes Dec 10, 2024
View reviewed changes
Copy link
Member

@seanmcgary seanmcgary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments

@BrendanCoughlan5 BrendanCoughlan5 self-assigned this Dec 11, 2024
@BrendanCoughlan5 BrendanCoughlan5 changed the title README nits + diagram README nits Dec 18, 2024
@seanmcgary seanmcgary changed the title README nits chore: update readme with docker port mapping Dec 20, 2024
@seanmcgary seanmcgary merged commit 331a8b2 into master Dec 20, 2024
4 of 5 checks passed
@seanmcgary seanmcgary deleted the nits+diagram branch December 20, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmcgary seanmcgary seanmcgary requested changes

@0xrajath 0xrajath Awaiting requested review from 0xrajath 0xrajath is a code owner automatically assigned from Layr-Labs/sidecar

Assignees

@BrendanCoughlan5 BrendanCoughlan5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrendanCoughlan5 @seanmcgary