Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge main into dev #205

Merged
merged 28 commits into from
Jan 15, 2025
Merged

chore: merge main into dev #205

merged 28 commits into from
Jan 15, 2025

Conversation

MegaRedHand
Copy link
Contributor

No description provided.

TomasArrachea and others added 15 commits December 17, 2024 17:25
Implement `send_tx_with_retries` to the Simple TxManager that sends a
transaction and retries using Exponential Backoff
This PR implements the method taken from Go SDK repo:
``` go
        func (r *ChainReader) QueryRegistrationDetail(
        opts *bind.CallOpts,
        operatorAddress common.Address,
        ) ([]bool, error) {
            operatorId, err := r.GetOperatorId(opts, operatorAddress)
            if err != nil {
                return nil, err
            }
            value, err := r.registryCoordinator.GetCurrentQuorumBitmap(opts, operatorId)
            if err != nil {
                return nil, err
            }
            numBits := value.BitLen()
            var quorums []bool
            for i := 0; i < numBits; i++ {
                quorums = append(quorums, value.Int64()&(1<<i) != 0)
            }
            return quorums, nil
        }
```

---------

Co-authored-by: supernovahs <supernovahs@proton.me>
Co-authored-by: tomasarrachea <tomas.arrachea@lambdaclass.com>
Co-authored-by: tomasarrachea <tomas.arrachea@lambdaclass.com>
Co-authored-by: tomasarrachea <tomas.arrachea@lambdaclass.com>
Co-authored-by: Pablo Deymonnaz <deymonnaz@gmail.com>
Co-authored-by: supernovahs <91280922+supernovahs@users.noreply.github.com>
Co-authored-by: supernovahs <supernovahs@proton.me>
Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
Co-authored-by: Pablo Deymonnaz <deymonnaz@gmail.com>
Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
Co-authored-by: supernovahs <91280922+supernovahs@users.noreply.github.com>
Co-authored-by: supernovahs <supernovahs@proton.me>
Co-authored-by: supernovahs <supernovahs@proton.me>
Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
I run into some problems when running the tests locally. This PR adds
the way I solved those, for future contributors.
Co-authored-by: Tomas <tomas.arrachea@lambdaclass.com>
Co-authored-by: Pablo Deymonnaz <deymonnaz@gmail.com>
Co-authored-by: supernovahs <supernovahs@proton.me>
@MegaRedHand MegaRedHand marked this pull request as ready for review January 9, 2025 15:59
@MegaRedHand MegaRedHand marked this pull request as draft January 9, 2025 19:18
@MegaRedHand MegaRedHand marked this pull request as ready for review January 9, 2025 20:49
@MegaRedHand MegaRedHand requested review from supernovahs and removed request for supernovahs January 10, 2025 21:17
@supernovahs
Copy link
Collaborator

this is using the latest slashing bindings?

@MegaRedHand
Copy link
Contributor Author

MegaRedHand commented Jan 10, 2025

No. It has the bindings from the v0.1.2 release. After this PR is merged I'll update the slashing branch with the changes (discarding stale ones), and regenerate bindings with ad1dc05

This PR fixes the CI by changing the docker setup action we were using
for docker's official one
MegaRedHand and others added 4 commits January 15, 2025 11:21
This PR includes the error message on the readme warning and fixes the
command listed.
Co-authored-by: supernovahs <supernovahs@proton.me>
@MegaRedHand
Copy link
Contributor Author

Seems like test_register_and_update_operator is failing on main. I'll revert 5ce424c for now and merge this. We can re-add it later.

@MegaRedHand
Copy link
Contributor Author

@supernovahs Just a heads-up, but we're already working on the fix (still debugging, though).

@MegaRedHand MegaRedHand merged commit 6ab2674 into dev Jan 15, 2025
3 checks passed
@MegaRedHand MegaRedHand deleted the merge-main branch January 15, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants