Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/rebase master #115

Merged
merged 107 commits into from
Dec 18, 2023
Merged

Chore/rebase master #115

merged 107 commits into from
Dec 18, 2023

Conversation

stevennevins
Copy link
Collaborator

No description provided.

steven and others added 30 commits November 8, 2023 12:42
fix: remove husky command that only needs to be run once
…umIndex

update nonSignerForQuorumIndex outside of loop
switch these addresses over from pre-prod environment to the addresses that EigenDA is using now
chore: repo cleanup -- fix contract addresses + add to .gitignore
generally i just removed testing of specific stake histories in favor of testing net outcomes. we can revisit these tests in a few weeks.
generally i just removed testing of specific stake histories in favor of testing net outcomes. we can revisit these tests in a few weeks.
ChaoticWalrus and others added 18 commits December 18, 2023 14:45
The `operatorId` in this check is already fetched from the `blsApkRegistry`
With the other changes, this return data is no longer necessary at all
I believe this change cuts down on the memory copying being done here
Likely not the ideal fix, but it gets the job done for the moment, at least.
`RegistryCoordinatorHarness.sol` -> `RegistryCoordinatorHarness.t.sol`
…ean (#104)

* fix: swap sign on sig checker withdrawal delay check

* fix: tiny_scalar_mul in BN254 and additional cleanup

- unify validateXAtBlockNumber style checks in registries
- checkSignatures changes below
- rename variables to be more readable
- validate input lengths for quorum and nonsigner params
- create signingQuorumBitmap using method with additional validation to avoid duplicates
- clarify commenting and style to be more consistent with rest of codebase
- cache state to avoid lookups in loop
- move total stake query to initial loop

* fix: refactor checkSignatures to remove an unneeded loop

- also optimizes BN254.hashG1Point
- also refactors checkSignatures to avoid negating pubkeys multiple times

* fix: stale stakes check should care about referenceBlockNumber

* fix: remove repeated storage read from loop

* chore: remove TODOs
* docs: add docs very wip

* docs: wip add docs and main README

* docs: wip main README

* docs: more wip

* docs: get docs to a good ish state

* docs: address feedback
)

* feat: reintroduce IServiceManager & ServiceManagerBase

These are useful concepts to form the single interaction point
where AVSs push data to EigenLayer.
The previous version focused on (unused) Slashing interactions,
whereas this version focused on the newer registration interactions.
TODO: modify the RegistryCoordinator to call the ServiceManagerBase
instead of calling the DelegationManager directly.

* feat: integrate RegistryCoordinator with ServiceManager(Base)

achieves the goal of a single interaction point with EigenLayer (per AVS).
all calls which push data to EigenLayer core are now forwarded via the ServiceManager(Base)

* fix: use correct addresses in test setup + functions

simple follow-up commit to fix breaking tests from last commit

* chore: restore optimizer_runs to 200

other changes in this PR remove enough from the size
of the RegistryCoordinator contract to make this possible.
200 runs is a wider industry default +
this should slightly decrease gas costs for users.
we can switch back to 100 in the future if we ever need to

* chore: add `setMetadataURI` function to IServiceManager interface

* feat: add operator strategy indexing to service manager (#110)

---------

Co-authored-by: Yash Patil <40046473+ypatil12@users.noreply.github.com>
Copy link
Contributor

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This'll unblock a bunch of things for me, thanks!

Copy link
Contributor

@ChaoticWalrus ChaoticWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM.
Was going to call out the weird whitespace diff but it looks like you caught that already 😄
I imagine there's probably some straggler imports but we can catch those later.
Would be good to call this out as a practice we're trying to observe going forwards.

@stevennevins
Copy link
Collaborator Author

All LGTM. Was going to call out the weird whitespace diff but it looks like you caught that already 😄 I imagine there's probably some straggler imports but we can catch those later. Would be good to call this out as a practice we're trying to observe going forwards.

Will do a look for stragglers, but pretty sure I got them all

@stevennevins
Copy link
Collaborator Author

All LGTM. Was going to call out the weird whitespace diff but it looks like you caught that already 😄 I imagine there's probably some straggler imports but we can catch those later. Would be good to call this out as a practice we're trying to observe going forwards.

updated 🫠

@stevennevins stevennevins merged commit a79742b into m2-mainnet Dec 18, 2023
@stevennevins stevennevins deleted the chore/rebase-master branch December 18, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants