[v2][node] Construct relay client from relay address from chain #931
Conversation
common/read_only_map.go
Outdated
| @@ -24,3 +26,7 @@ func (m *ReadOnlyMap[K, V]) Keys() []K { | |||
| func (m *ReadOnlyMap[K, V]) Len() int { | |||
| return len(m.data) | |||
| } | |||
|
|
|||
| func (m *ReadOnlyMap[K, V]) Equal(data map[K]V) bool { | |||
| return reflect.DeepEqual(m.data, data) | |||
There was a problem hiding this comment.
Reflection may have perf issue, so may be not a good choice for non testing use.
| @@ -161,7 +161,7 @@ func (b *BlobHeader) GetEncodingParams(blobParams *core.BlobVersionParameters) ( | |||
| }, nil | |||
| } | |||
|
|
|||
| type RelayKey uint16 | |||
| type RelayKey = uint16 | |||
There was a problem hiding this comment.
What's the consideration of changing to alias? The current one provides type safety which is often desired
There was a problem hiding this comment.
It's mostly to interoperate with chainio library which still lives in core and can't import v2 due to import cycles.
So chainio library uses uint16 instead of RelayKey type, and I updated this to type alias to convert the output from chainio without an explicit conversion method
| continue | ||
| } | ||
|
|
||
| relayClient, err := clients.NewRelayClient(&clients.RelayClientConfig{ |
There was a problem hiding this comment.
Relay url may be updated much more frequently than protocol params, should it be in a different interval/thread?
There was a problem hiding this comment.
Yeah, I agree in terms of relative frequency, but I still think the frequency for new relays being added and getting used would be in order of hours if not days.
8975980 to
d61d559
Compare
There was a problem hiding this comment.
Perhaps this isn't the correct PR to add signing of GetChunks() requests via auth.SignGetChunksRequest(keys *core.KeyPair, request *pb.GetChunksRequest) []byte, just pointing out that its something we still need to do. We can still test without this by setting the flag AuthenticationDisabled=true, but that's not something we will want to deploy to mainnet.
d61d559 to
6e73361
Compare
6e73361 to
139eb00
Compare
| @@ -34,7 +34,8 @@ type RawBundles struct { | |||
| } | |||
|
|
|||
| func (n *Node) DownloadBundles(ctx context.Context, batch *corev2.Batch, operatorState *core.OperatorState) ([]*corev2.BlobShard, []*RawBundles, error) { | |||
| if n.RelayClient == nil { | |||
| relayClient, ok := n.RelayClient.Load().(clients.RelayClient) | |||
There was a problem hiding this comment.
will this panic if Load() returns nil?
There was a problem hiding this comment.
No. In that case, relayClient will be nil and ok will be false
Why are these changes needed?
Node creates relay client with relay address from chain
Checks