Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The Disperser in particular the retrieval latency was 60+ seconds, when there was high traffic and/or large blobs.
There was due to inefficient memory management when dealing with blob buffer from S3, making it spend a lot of CPU/time on memory allocation and GC.
Tested:
From local retrieval query for a large blob,
Before:
After:
From pprof:
Before:
After:
Checks