Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] Disperser request validation #915

Merged
merged 2 commits into from
Nov 21, 2024
Merged

[v2] Disperser request validation #915

merged 2 commits into from
Nov 21, 2024

Conversation

ian-shim
Copy link
Contributor

Why are these changes needed?

More validations on dispersal request

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim marked this pull request as ready for review November 20, 2024 06:44
cody-littley
cody-littley approved these changes Nov 20, 2024
View reviewed changes
disperser/apiserver/disperse_blob_v2.go Outdated Show resolved Hide resolved
disperser/cmd/apiserver/flags/flags.go Outdated Show resolved Hide resolved
@ian-shim ian-shim requested a review from anupsv November 20, 2024 18:39
@ian-shim ian-shim force-pushed the disperser-header-validation branch from b49f4f8 to 5398e7d Compare November 20, 2024 21:02
@ian-shim ian-shim merged commit 6ada199 into Layr-Labs:master Nov 21, 2024
6 checks passed
anupsv
anupsv reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@anupsv anupsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anupsv anupsv anupsv left review comments

@cody-littley cody-littley cody-littley approved these changes

@mooselumph mooselumph Awaiting requested review from mooselumph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ian-shim @anupsv @cody-littley