Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Remove rate limiter from disperser #909

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

ian-shim
Copy link
Contributor

Why are these changes needed?

Ratelimiter will be replaced with payment meterer

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim marked this pull request as ready for review November 19, 2024 17:46
@anupsv
Copy link
Contributor

anupsv commented Nov 20, 2024

Can we link the PR which implemented the payment metering.

@ian-shim
Copy link
Contributor Author

Can we link the PR which implemented the payment metering.

We don't have it yet 😅 @hopeyen is working on it

@ian-shim ian-shim merged commit f7ab152 into Layr-Labs:master Nov 20, 2024
7 checks passed
@hopeyen
Copy link
Contributor

hopeyen commented Nov 21, 2024

Can we link the PR which implemented the payment metering.

We don't have it yet 😅 @hopeyen is working on it

It's in draft state here. this actually answers one of my questions in the draft on if payment field isn't available should we fallback to rate limiter, which is nope looking at this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants