[v2] Inabox Environment Setup #901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ae84dd2 to
e2bd06d
Compare
e2bd06d to
97fdefc
Compare
cody-littley
approved these changes
Nov 18, 2024
Comment on lines
+631
to
+690
| func (vars ControllerVars) getEnvMap() map[string]string { | ||
| v := reflect.ValueOf(vars) | ||
| envMap := make(map[string]string) | ||
| for i := 0; i < v.NumField(); i++ { | ||
| envMap[v.Type().Field(i).Name] = v.Field(i).String() | ||
| } | ||
| return envMap | ||
| } |
There was a problem hiding this comment.
Although I like that this is automated, it's different than how we are reading environment variables elsewhere. Is this a pattern that we use just for inabox, or a new pattern that you think we should adopt elsewhere as well?
97fdefc to
54f455b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Sets up v2 components in local inabox environment.
Checks