Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update v2 disperser protos #816

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Update v2 disperser protos #816

merged 1 commit into from
Oct 22, 2024

Conversation

ian-shim
Copy link
Contributor

Why are these changes needed?

Updating blob header & cert schema

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim marked this pull request as ready for review October 17, 2024 05:07
@ian-shim ian-shim force-pushed the update-v2-disperser-protos branch from 8582bdd to 03cdacb Compare October 17, 2024 05:16
cody-littley
cody-littley reviewed Oct 17, 2024
View reviewed changes
api/proto/common/common.proto Outdated Show resolved Hide resolved
api/proto/common/common.proto Outdated Show resolved Hide resolved
cody-littley
cody-littley approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@cody-littley cody-littley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this merging once we sort out whether or not repeated string relays = 4; should actually be something like repeated uint32.

@ian-shim ian-shim force-pushed the update-v2-disperser-protos branch from 03cdacb to 7a5abf6 Compare October 18, 2024 22:20
mooselumph
mooselumph reviewed Oct 18, 2024
View reviewed changes
api/proto/common/v2/common.proto Outdated
uint32 version = 1;
repeated uint32 quorum_numbers = 2;
common.BlobCommitment commitment = 3;
bytes payment_header_hash = 4;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just include the payment header now so as to minimize api changes in the future?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we plan on including payment header in blob header in the future? I thought it was going to be passed in as a separate field in dispersal request

api/proto/common/v2/common.proto Outdated Show resolved Hide resolved
@ian-shim ian-shim force-pushed the update-v2-disperser-protos branch from 7a5abf6 to dbe355a Compare October 21, 2024 16:47
@ian-shim ian-shim force-pushed the update-v2-disperser-protos branch from dbe355a to 0404df0 Compare October 21, 2024 23:34
@ian-shim ian-shim merged commit 7e0579e into Layr-Labs:master Oct 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cody-littley cody-littley cody-littley approved these changes

@mooselumph mooselumph mooselumph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ian-shim @mooselumph @cody-littley