V2 Retrieval Isolation #1181
V2 Retrieval Isolation #1181
Conversation
6da5a24 to
f33b818
Compare
| @@ -252,19 +253,33 @@ func NewConfig(ctx *cli.Context) (*Config, error) { | |||
| return nil, fmt.Errorf("v2 dispersal port (NODE_V2_DISPERSAL_PORT) must be specified if v2 is enabled") | |||
| } | |||
| } else { | |||
| _, err = strconv.Atoi(v2DispersalPort) | |||
| // TODO: should we mandate v2Enabled == true | |||
There was a problem hiding this comment.
corner case: I think this and line:269 needs to check that v2Enabled==true This will avoid user errors of adding a v2 port in the flag without enabling v2.
cc: @ian-shim holding off on making this change to confirm intent.
There was a problem hiding this comment.
I think that makes sense. Although we would need to update this logic when we update the flags that specify the mode
f33b818 to
a34665a
Compare
- Updates operator socket format to host:v1DispersalPort;v1RetrievalPort;v2DispersalPort;V2RetrievalPort
- Refactors parseOperatorSocket to handle v2 retrieval socket with strict port validation
- Adds ValidatePort() to core utils
- Adds stricter validation for operator sockets. Valid formats:
- host:v1DispersalPort;v1RetrievalPort
- host:v1DispersalPort;v1RetrievalPort;v2DispersalPort;V2RetrievalPort
- Adds host validation supporting both FQDN and IP addr
- Registers node for the new V2 retrieval service
a34665a to
c446a82
Compare
| } | ||
|
|
||
| type StakeAmount = *big.Int | ||
|
|
||
| func ParseOperatorSocket(socket string) (host string, dispersalPort string, retrievalPort string, v2DispersalPort string, err error) { | ||
| func ParseOperatorSocket(socket string) (host, v1DispersalPort, v1RetrievalPort, v2DispersalPort, v2RetrievalPort string, err error) { |
There was a problem hiding this comment.
maybe it's time to make OperatorSocket a struct and return the struct?
Number of return variables is getting big 🤣
| @@ -252,19 +253,33 @@ func NewConfig(ctx *cli.Context) (*Config, error) { | |||
| return nil, fmt.Errorf("v2 dispersal port (NODE_V2_DISPERSAL_PORT) must be specified if v2 is enabled") | |||
| } | |||
| } else { | |||
| _, err = strconv.Atoi(v2DispersalPort) | |||
| // TODO: should we mandate v2Enabled == true | |||
There was a problem hiding this comment.
I think that makes sense. Although we would need to update this logic when we update the flags that specify the mode
| @@ -109,5 +109,34 @@ func RunServers(serverV1 *Server, serverV2 *ServerV2, config *node.Config, logge | |||
| } | |||
| }() | |||
|
|
|||
| go func() { | |||
There was a problem hiding this comment.
we should remove serverV2 from L102 and update the server options in L95
Why are these changes needed?
host:v1DispersalPort;v1RetrievalPort;v2DispersalPort;V2RetrievalPorthost:v1DispersalPort;v1RetrievalPorthost:v1DispersalPort;v1RetrievalPort;v2DispersalPort;V2RetrievalPortChecks