Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: proto on paymentHeader #1178

Merged
merged 3 commits into from
Jan 29, 2025
Merged

docs: proto on paymentHeader #1178

merged 3 commits into from
Jan 29, 2025
+175 −13

Conversation

hopeyen
Copy link
Contributor

@hopeyen hopeyen commented Jan 28, 2025

Why are these changes needed?

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

samlaf
samlaf reviewed Jan 28, 2025
View reviewed changes
api/proto/common/v2/common_v2.proto Outdated Show resolved Hide resolved
api/proto/common/v2/common_v2.proto Outdated Show resolved Hide resolved
api/proto/common/v2/common_v2.proto Outdated Show resolved Hide resolved
@hopeyen hopeyen force-pushed the hope/doc-payment-proto branch from 9f8bf93 to 1953089 Compare January 29, 2025 19:45
@hopeyen hopeyen merged commit e8a9055 into master Jan 29, 2025
9 checks passed
@hopeyen hopeyen deleted the hope/doc-payment-proto branch January 29, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlaf samlaf samlaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hopeyen @samlaf