Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suppport for blob feed API at dataapi #1116

Merged
merged 11 commits into from
Jan 16, 2025

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented Jan 15, 2025

Why are these changes needed?

Implementing dataapi v2 (#955)

This supports the blob feed API where clients can query stream of blobs in the past N seconds, with pagination.

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

// @Summary Fetch blob feed
// @Tags Blob
// @Produce json
// @Param end query string false "Fetch blobs up to the end time (ISO 8601 format: 2006-01-02T15:04:05Z) [default: now]"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is formatted by swagger. It's perfectly aligned in editor locally, not sure why they appear misaligned here.

Copy link

@merli-eigenlabs merli-eigenlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jianoaix jianoaix merged commit c4567f9 into Layr-Labs:master Jan 16, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants