Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start on-chain refresh #1083

Merged
merged 3 commits into from
Jan 8, 2025
Merged

start on-chain refresh #1083

merged 3 commits into from
Jan 8, 2025

Conversation

hopeyen
Copy link
Contributor

@hopeyen hopeyen commented Jan 8, 2025

Why are these changes needed?

meterer.Start() wasn't called before

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@hopeyen hopeyen force-pushed the hope/on-chain-refresh branch from 5b45c3f to 8dca7a2 Compare January 8, 2025 18:34
@hopeyen hopeyen force-pushed the hope/on-chain-refresh branch from 8dca7a2 to adc4bb2 Compare January 8, 2025 18:41
@hopeyen hopeyen merged commit f6ee5ca into master Jan 8, 2025
7 checks passed
@hopeyen hopeyen deleted the hope/on-chain-refresh branch January 8, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cody-littley cody-littley cody-littley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hopeyen @cody-littley