Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sigmap-EDAP-01): Missing nil Checks On Parameters Of Incoming Requests #231

Merged
merged 3 commits into from
Jan 9, 2025
Merged

fix(sigmap-EDAP-01): Missing nil Checks On Parameters Of Incoming Requests #231

merged 3 commits into from
Jan 9, 2025

Conversation

epociask
Copy link
Collaborator

@epociask epociask commented Jan 9, 2025

Fixes Issue

Fixes #

Changes proposed

Screenshots (Optional)

Note to reviewers

@epociask epociask marked this pull request as ready for review January 9, 2025 18:07
@epociask epociask requested review from samlaf, litt3 and bxue-l2 January 9, 2025 18:13
samlaf
samlaf approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. check for nils to return error early, but still use the protobuf getter methods in case we forgot to check some nil statement or the code ever gets refactored etc.

@epociask epociask merged commit f34d87a into main Jan 9, 2025
9 checks passed
@epociask epociask deleted the epociask--fix-EDAP-01 branch January 9, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litt3 litt3 litt3 approved these changes

@samlaf samlaf samlaf approved these changes

@bxue-l2 bxue-l2 Awaiting requested review from bxue-l2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epociask @samlaf @litt3