feat: add GET header to return raw blob #222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samlaf
reviewed
Dec 21, 2024
Comment on lines
+70
to
+71
| // ToDo still not correct impl | ||
| func (e Store) GetRaw(ctx context.Context, key []byte) ([]byte, error) { |
There was a problem hiding this comment.
I'm confused, what is this supposed to do? It's doing the exact same thing as Get() right now.
|
Close in favor of this PR, Layr-Labs/hokulea#19 Can re-open if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a POC for returning raw codec-ed blob.
This POC is only tested against raw blob and other store getRaw isn't tested.
This POC relies on http header on the http GET method to indicate if it wants the raw blob.
Recall suppose our blob is called A, the final output is IFFT(codec(A)).
The raw blob return you codec(A). An alternative way to reconstruct the header again inside the client code, which looks more verbose.
This is only used for internal testing, the final approach is yet to be decided.