feat: Fault Testing Support - fix tests

Makefile

@@ -38,11 +38,11 @@ clean:
 test:
 	go test -v ./... -parallel 4 
 
-e2e-test: stop-minio run-minio
+e2e-test: run-minio
 	$(E2ETEST) && \
 	make stop-minio
 
-holesky-test: stop-minio run-minio
+holesky-test: run-minio
 	$(HOLESKYTEST) && \
 	make stop-minio
 

e2e/server_test.go

@@ -95,6 +95,14 @@ func TestProxyClient(t *testing.T) {
 }
 
 func TestProxyServerFaultMode(t *testing.T) {
+	if !runIntegrationTests {
+		t.Skip("Skipping test as INTEGRATION or TESTNET env var not set")
+	}
+
+	if runTestnetIntegrationTests {
+		t.Skip("Skipping test since fault mode is only supported for memstore implementations")
+	}
+
 	fc := &store.FaultConfig{
 		Actors: map[string]store.Behavior{
 			"sequencer": {
@@ -197,6 +205,10 @@ func TestProxyClientWithOversizedBlob(t *testing.T) {
 }
 
 func TestProxyClient_MultiSameContentBlobs_SameBatch(t *testing.T) {
+	if !runIntegrationTests && !runTestnetIntegrationTests {
+		t.Skip("Skipping test as INTEGRATION or TESTNET env var not set")
+	}
+
 	t.Parallel()
 
 	ts, kill := e2e.CreateTestSuite(t, useMemory(), false, nil)

e2e/setup.go

@@ -120,6 +120,11 @@ func CreateTestSuite(t *testing.T, useMemory bool, useS3 bool, fc *store.FaultCo
 		ctx,
 		log,
 	)
+
+	if fc != nil {
+		store.GetMemStore().SetFaultConfig(fc)
+	}
+
 	require.NoError(t, err)
 	server := server.NewServer(host, 0, store, log, metrics.NoopMetrics)
 

fault.example.json

@@ -1,6 +1,6 @@
 {
     "all": {
         "mode": "interval_byzantine",
-        "interval": 2
+        "interval": 1
     }
 }

server/server.go

@@ -12,7 +12,6 @@ import (
 	"time"
 
 	"github.com/Layr-Labs/eigenda-proxy/commitments"
-	"github.com/Layr-Labs/eigenda-proxy/common"
 	"github.com/Layr-Labs/eigenda-proxy/metrics"
 	"github.com/Layr-Labs/eigenda-proxy/store"
 	"github.com/ethereum-optimism/optimism/op-service/rpc"
@@ -37,7 +36,7 @@ const (
 
 type Store interface {
 	// Get retrieves the given key if it's present in the key-value data store.
-	Get(ctx context.Context, key []byte, domain common.DomainType) ([]byte, error)
+	Get(ctx context.Context, key []byte) ([]byte, error)
 	// Put inserts the given value into the key-value data store.
 	Put(ctx context.Context, value []byte) (key []byte, err error)
 	// Stats returns the current usage metrics of the key-value data store.

store/memory.go

@@ -76,6 +76,12 @@ func NewMemStore(ctx context.Context, verifier *verify.Verifier, l log.Logger, m
 	return store, nil
 }
 
+func (e *MemStore) SetFaultConfig(fc *FaultConfig) {
+	e.Lock()
+	defer e.Unlock()
+	e.faultCfg = fc
+}
+
 func (e *MemStore) EventLoop(ctx context.Context) {
 	timer := time.NewTicker(DefaultPruneInterval)
 
@@ -131,7 +137,7 @@ func (e *MemStore) Get(ctx context.Context, commit []byte) ([]byte, error) {
 
 	switch behavior.Mode {
 		case Honest:
-			return encodedBlob, nil
+			return decodedBlob, nil
 		case Byzantine:
 			return e.corruptBlob(decodedBlob), nil