This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
testing: simplify i18n mock creation #447
Comments
@jpommerening sure that we need a context mock? I would think an ideal axI18n mock would not even talk to the event bus. Instead, the test could call some API like |
Good point, agree 💯 |
Implemented on BREAKING CHANGEThe API to Now, an axI18n mock can be created…
Also, the mock now exposes a method |
x1B
added a commit
to LaxarJS/laxar-mocks
that referenced
this issue
Apr 7, 2017
x1B
added a commit
to LaxarJS/laxar-mocks
that referenced
this issue
Apr 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently, creating an i18n mock requires an actual i18n instance:
This is ok inside LaxarJS and bearable in widgets, but i18n instances are hard to come by when testing controls, leading to reimplementation of the i18n functionality, making tests prone to mask problems when the i18n API or behaviour changes.
It would be really nice if one could instead create an i18n mock with:
(The need for this was identified in LaxarJS/laxar-mocks#50)
The text was updated successfully, but these errors were encountered: