Skip to content
This repository has been archived by the owner on May 22, 2023. It is now read-only.

fixtures: refactor fixtures parameter into module-method #46

Closed
x1B opened this issue Feb 20, 2017 · 2 comments
Closed

fixtures: refactor fixtures parameter into module-method #46

x1B opened this issue Feb 20, 2017 · 2 comments
Labels
breaking epic: developer tools type: enhancement version: 2.x
Milestone
v2.0.0

Comments

@x1B
Copy link
Member

x1B commented Feb 20, 2017

Currently, fixtures are provided to laxar-mocks by setting initializing special properties of the fixtures object export before loading a test module.

For better documentability, a method (e.g. init) should be used, that clearly explains the use in spec-runners and the associated module statefulness.
@x1B x1B added this to the v2.0.0 milestone Feb 20, 2017
@x1B x1B added the breaking label Feb 20, 2017
@x1B
Copy link
Member Author

x1B commented Feb 20, 2017

Of course, the spec-loader needs to be adjusted accordingly.

x1B added a commit that referenced this issue Feb 21, 2017
@x1B
(#46) pass spec fixtures using the init method
94a2af0
@x1B
Copy link
Member Author

x1B commented Feb 21, 2017

Implemented on master (v2.0.0).

BREAKING CHANGE

The way to pass fixtures (adapter, artifacts, descriptor) from a spec-runner into laxar-mocks has changed: previously, these options had to be passed as properties of the fixtures export. Now, the init method must be used.

@x1B x1B closed this as completed Feb 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
breaking epic: developer tools type: enhancement version: 2.x
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
2 participants
@x1B @mkemmann