Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ 2 icons: Banxo, RATP #2144

Closed
wants to merge 1 commit into from

Conversation

Ender-events
Copy link

Description

Add 2 icons (Caisse d'epargne banxo, ratp)

Icons addition information

Added

Banxo (com.caisseepargne.android.mobilebanking)
Bonjour RATP (com.fabernovel.ratp)

Contributor's checklist

  • I followed the Lawnicons guidelines and will make changes if someone suggests. I will also make sure that Lawnicons builds correctly.

@github-actions github-actions bot added the icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. label Jun 9, 2024
Copy link
Contributor

github-actions bot commented Jun 9, 2024

Thanks for your contribution!

While waiting for a review from our team, you can do a self-review to ensure that your icons are suitable for Lawnicons.

Canvas and sizes

  1. Canvas: 192×192px.
  2. Non-square icons: the long side of the icons should be 160px.
  3. Square icons: 154×154px.

Color, stroke width and rounding

  1. Color: black #000.
  2. No fill. Base stroke width: 12px. 14px, 10px, 8px — depending on the shape of the icons. 6px — for fine details.
  3. Rounded ends and joins. 90° corners are rounded by 6-32px.

Naming

  1. Names should match the official app name and contain no additional text.
  2. If the original name is not in English, then add a localized (or transliterated) one to it using ~~.
    Example: フールー ~~ Hulu.
  3. The names of the drawables should repeat the names of the apps if nothing prevents it.

Quality

  1. Ensure that icons are easily recognizable.
  2. Align icons to the visual center.
  3. Avoid blackness or noticable black spots by reducing the stroke width or simplifying the icons.
  4. Avoid close distances between strokes. The icons on the phone screen will be smaller, so the small distances between the strokes will stick together.
  5. Avoid drastic changes in stroke widths. When the strokes next to each other differ in width by 4px or more, the icon will look sloppy.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the icon size is too small;
  • try to remove the fill by making 6x6px ellipse with 6px stroke width. The result is likely to be comparable to what was expected, so the fill can be avoided.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the icon size is too small;
  • replace the fill with 12px stroke.

Copy link
Collaborator

@x9136 x9136 Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drawable="caisseepargne_banxo" → drawable="banxo"
caisseepargne_banxo.svg → banxo.svgs

drawable="hello_ratp" → drawable="bonjour_ratp"
hello_ratp.svg → bonjour_ratp.svgs
Note: there is an inaccuracy in the naming guides, I will take this into account later.

@x9136 x9136 added the rework The team has requested changes in the issue or PR. label Jun 12, 2024
@I21b I21b mentioned this pull request Jun 14, 2024
1 task
@Ender-events
Copy link
Author

If #2159 is accepted, you can close this PR

This was referenced Jun 21, 2024
@x9136
Copy link
Collaborator

x9136 commented Jun 26, 2024

#2174

@x9136 x9136 closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. rework The team has requested changes in the issue or PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants